_Bastler/partey_workadventure
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

remove unused LIVE_RELOAD variable

Browse Source
This commit is contained in:
Lukas Hass 2022-02-15 20:28:52 +01:00
parent 620e218612
commit 72c35e2d06
No known key found for this signature in database
GPG Key ID: 7C8CEF72C4039178
3 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/end_to_end_tests.yml vendored
View File

@ -69,7 +69,7 @@ jobs:
run: sudo chown 1000:1000 -R . run: sudo chown 1000:1000 -R .
- name: "Start environment" - name: "Start environment"
run: LIVE_RELOAD=0 docker-compose up -d run: docker-compose up -d
- name: "Wait for environment to build (and downloading testcafe image)" - name: "Wait for environment to build (and downloading testcafe image)"
run: (docker-compose -f docker-compose.testcafe.yml build &) && docker-compose logs -f --tail=0 front | grep -q "Compiled successfully" run: (docker-compose -f docker-compose.testcafe.yml build &) && docker-compose logs -f --tail=0 front | grep -q "Compiled successfully"

8
CONTRIBUTING.md
View File

@ -83,16 +83,12 @@ End-to-end tests are available in the "/tests" directory.
To run these tests locally: To run these tests locally:
```console ```console
$ LIVE_RELOAD=0 docker-compose up -d $ docker-compose up -d
$ cd tests $ cd tests
$ npm install $ npm install
$ npm run test $ npm run test
``` ```
Note: If your tests fail on a Javascript error in "sockjs", this is due to the
Webpack live reload. The Webpack live reload feature is conflicting with testcafe. This is why we recommend starting
WorkAdventure with the `LIVE_RELOAD=0` environment variable.
End-to-end tests can take a while to run. To run only one test, use: End-to-end tests can take a while to run. To run only one test, use:
```console ```console
@ -103,7 +99,7 @@ You can also run the tests inside a container (but you will not have visual feed
the local tests). the local tests).
```console ```console
$ LIVE_RELOAD=0 docker-compose up -d $ docker-compose up -d
# Wait 2-3 minutes for the environment to start, then: # Wait 2-3 minutes for the environment to start, then:
$ PROJECT_DIR=$(pwd) docker-compose -f docker-compose.testcafe.yml up $ PROJECT_DIR=$(pwd) docker-compose -f docker-compose.testcafe.yml up
``` ```

1
docker-compose.yaml
View File

@ -52,7 +52,6 @@ services:
MAX_USERNAME_LENGTH: "$MAX_USERNAME_LENGTH" MAX_USERNAME_LENGTH: "$MAX_USERNAME_LENGTH"
DISABLE_ANONYMOUS: "$DISABLE_ANONYMOUS" DISABLE_ANONYMOUS: "$DISABLE_ANONYMOUS"
OPID_LOGIN_SCREEN_PROVIDER: "$OPID_LOGIN_SCREEN_PROVIDER" OPID_LOGIN_SCREEN_PROVIDER: "$OPID_LOGIN_SCREEN_PROVIDER"
LIVE_RELOAD: "$LIVE_RELOAD:-true"
command: yarn run start command: yarn run start
volumes: volumes:
- ./front:/usr/src/app - ./front:/usr/src/app