From 72c35e2d06cffd33f276dbfe47919fb99d341b98 Mon Sep 17 00:00:00 2001
From: Lukas Hass <lukas@slucky.de>
Date: Tue, 15 Feb 2022 20:28:52 +0100
Subject: [PATCH] remove unused LIVE_RELOAD variable

---
 .github/workflows/end_to_end_tests.yml | 2 +-
 CONTRIBUTING.md                        | 8 ++------
 docker-compose.yaml                    | 1 -
 3 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/end_to_end_tests.yml b/.github/workflows/end_to_end_tests.yml
index f9dc832c..f236f72b 100644
--- a/.github/workflows/end_to_end_tests.yml
+++ b/.github/workflows/end_to_end_tests.yml
@@ -69,7 +69,7 @@ jobs:
         run: sudo chown 1000:1000 -R .
 
       - name: "Start environment"
-        run: LIVE_RELOAD=0 docker-compose up -d
+        run: docker-compose up -d
 
       - name: "Wait for environment to build (and downloading testcafe image)"
         run: (docker-compose -f docker-compose.testcafe.yml build &) && docker-compose logs -f --tail=0 front | grep -q "Compiled successfully"
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 2d3f5d0b..491c74f4 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -83,16 +83,12 @@ End-to-end tests are available in the "/tests" directory.
 To run these tests locally:
 
 ```console
-$ LIVE_RELOAD=0 docker-compose up -d
+$ docker-compose up -d
 $ cd tests
 $ npm install
 $ npm run test
 ```
 
-Note: If your tests fail on a Javascript error in "sockjs", this is due to the
-Webpack live reload. The Webpack live reload feature is conflicting with testcafe. This is why we recommend starting
-WorkAdventure with the `LIVE_RELOAD=0` environment variable.
-
 End-to-end tests can take a while to run. To run only one test, use:
 
 ```console
@@ -103,7 +99,7 @@ You can also run the tests inside a container (but you will not have visual feed
 the local tests).
 
 ```console
-$ LIVE_RELOAD=0 docker-compose up -d
+$ docker-compose up -d
 # Wait 2-3 minutes for the environment to start, then:
 $ PROJECT_DIR=$(pwd) docker-compose -f docker-compose.testcafe.yml up
 ```
diff --git a/docker-compose.yaml b/docker-compose.yaml
index 8489b336..2bbc6c0a 100644
--- a/docker-compose.yaml
+++ b/docker-compose.yaml
@@ -52,7 +52,6 @@ services:
       MAX_USERNAME_LENGTH: "$MAX_USERNAME_LENGTH"
       DISABLE_ANONYMOUS: "$DISABLE_ANONYMOUS"
       OPID_LOGIN_SCREEN_PROVIDER: "$OPID_LOGIN_SCREEN_PROVIDER"
-      LIVE_RELOAD: "$LIVE_RELOAD:-true"
     command: yarn run start
     volumes:
       - ./front:/usr/src/app