_Bastler/partey_workadventure
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixing a freeze in MapStore on several unsubscribes

Browse Source 
For some reason (I could not reproduce this in unit tests alas), the unsubscribe function
could be called several times in a row, leading to a complete map freeze.

Closes #1736
This commit is contained in:
David Négrier 2022-01-28 09:58:24 +01:00
parent 0d4befc850
commit e43c4cd5ae
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
front/src/Stores/Utils/MapStore.ts
View File

@ -96,6 +96,7 @@ export class MapStore<K, V> extends Map<K, V> implements Readable<Map<K, V>> {
const unsubscribe = storeByKey.subscribe((newMapValue) => { const unsubscribe = storeByKey.subscribe((newMapValue) => {
if (unsubscribeDeepStore) { if (unsubscribeDeepStore) {
unsubscribeDeepStore(); unsubscribeDeepStore();
unsubscribeDeepStore = undefined;
} }
if (newMapValue === undefined) { if (newMapValue === undefined) {
set(undefined); set(undefined);
@ -115,6 +116,7 @@ export class MapStore<K, V> extends Map<K, V> implements Readable<Map<K, V>> {
unsubscribe(); unsubscribe();
if (unsubscribeDeepStore) { if (unsubscribeDeepStore) {
unsubscribeDeepStore(); unsubscribeDeepStore();
unsubscribeDeepStore = undefined;
} }
}; };
}); });