Fixing memory leak with listeners

The listeners from MediaManager and SimplePeer were never removed, leading to a huge amount of listeners all over the applications when switching regularly of scene.
2020-06-23 14:56:57 +02:00
parent 12ce0e16ed
commit d78006e106
3 changed files with 56 additions and 30 deletions
@@ -190,6 +190,7 @@ export class GameScene extends Phaser.Scene {
                console.log('Player disconnected from server. Reloading scene.');

                this.simplePeer.closeAllConnections();
+                this.simplePeer.unregister();

                const key = 'somekey'+Math.round(Math.random()*10000);
                const game : Phaser.Scene = GameScene.createFromUrl(this.MapUrlFile, this.instance, key);
@@ -610,6 +611,7 @@ export class GameScene extends Phaser.Scene {
        if(nextSceneKey){
            // We are completely destroying the current scene to avoid using a half-backed instance when coming back to the same map.
            this.connection.closeConnection();
+            this.simplePeer.unregister();
            this.scene.stop();
            this.scene.remove(this.scene.key);
            this.scene.start(nextSceneKey.key, {