_Bastler/partey_workadventure
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Better e2e tests (#1959)

Browse Source 
* Adding a timeout to wait for old map to be correctly loaded

* Adding an exception for E2E tests to load a local map as if it was remote.
This commit is contained in:
David Négrier 2022-03-11 10:29:42 +01:00 committed by GitHub
parent 0196eae055
commit d3862a3afd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
back/src/Services/MapFetcher.ts
View File

@ -43,6 +43,15 @@ class MapFetcher {
* @private
*/
async isLocalUrl(url: string): Promise<boolean> {
if (
url ===
"http://play.workadventure.localhost/_/global/maps.workadventure.localhost/tests/Variables/shared_variables.json"
) {
// This is an ugly exception case needed for the E2E test at "tests/tests/variables.spec.ts"
// Otherwise, we cannot test locally maps that are... not local.
return false;
}
const urlObj = new URL(url);
if (urlObj.hostname === "localhost" || urlObj.hostname.endsWith(".localhost")) {
return true;

8
tests/tests/variables.spec.ts
View File

@ -142,6 +142,9 @@ test.describe('Variables', () => {
await login(page, 'Alice', 2);
// Wait for page to load before copying file (it seems the await above does not 100% fills its role otherwise).
await timeout(3000);
// Let's REPLACE the map by a map that has a new variable
// At this point, the back server contains a cache of the old map (with no variables)
fs.copyFileSync(
@ -162,3 +165,8 @@ test.describe('Variables', () => {
await assertLogMessage(page2, 'SUCCESS!');
});
});
function timeout(ms) {
return new Promise(resolve => setTimeout(resolve, ms));
}