Merge pull request #103 from thecodingmachine/catching_errors

Catching errors in socket callbacks

back/src/Controller/IoSocketController.ts

@@ -88,6 +88,7 @@ export class IoSocketController {
                         y: user y position on map
             */
             socket.on(SockerIoEvent.JOIN_ROOM, (message: string) => {
+                try {
                     let messageUserPosition = this.hydrateMessageReceive(message);
                     if (messageUserPosition instanceof Error) {
                         return socket.emit(SockerIoEvent.MESSAGE_ERROR, JSON.stringify({message: messageUserPosition.message}))
@@ -112,9 +113,14 @@ export class IoSocketController {
                     this.refreshUserPosition(Client);
 
                     socket.to(messageUserPosition.roomId).emit(SockerIoEvent.JOIN_ROOM, messageUserPosition.toString());
+                } catch (e) {
+                    console.error('An error occurred on "join_room" event');
+                    console.error(e);
+                }
             });
 
             socket.on(SockerIoEvent.USER_POSITION, (message: string) => {
+                try {
                     let messageUserPosition = this.hydrateMessageReceive(message);
                     if (messageUserPosition instanceof Error) {
                         return socket.emit(SockerIoEvent.MESSAGE_ERROR, JSON.stringify({message: messageUserPosition.message}));
@@ -127,6 +133,10 @@ export class IoSocketController {
 
                     //refresh position of all user in all rooms in real time
                     this.refreshUserPosition(Client);
+                } catch (e) {
+                    console.error('An error occurred on "user_position" event');
+                    console.error(e);
+                }
         });
 
             socket.on(SockerIoEvent.WEBRTC_SIGNAL, (message: string) => {
@@ -153,6 +163,7 @@ export class IoSocketController {
             });
 
             socket.on(SockerIoEvent.DISCONNECT, () => {
+                try {
                     let Client = (socket as ExSocketInterface);
                     this.sendDisconnectedEvent(Client);
 
@@ -171,6 +182,10 @@ export class IoSocketController {
                     delete Client.roomId;
                     delete Client.token;
                     delete Client.position;
+                } catch (e) {
+                    console.error('An error occurred on "disconnect"');
+                    console.error(e);
+                }
             });
         });
     }

front/src/Phaser/Entity/PlayableCaracter.ts

@@ -49,6 +49,8 @@ export class PlayableCaracter extends Phaser.Physics.Arcade.Sprite {
         this.setSize(16, 16); //edit the hitbox to better match the character model
         this.setOffset(8, 16);
         this.setDepth(-1);
+
+        this.scene.events.on('postupdate', this.postupdate.bind(this));
     }
 
     move(x: number, y: number) {
@@ -69,14 +71,14 @@ export class PlayableCaracter extends Phaser.Physics.Arcade.Sprite {
         if (this.bubble) {
             this.bubble.moveBubble(this.x, this.y);
         }
-        this.updatePlayerNamePosition(this.x, this.y);
 
         //update depth user
         this.setDepth(this.y);
     }
 
-    updatePlayerNamePosition(x: number, y: number){
+    postupdate(time: number, delta: number) {
-        this.playerName.setPosition(x, y - 25);
+        //super.update(delta);
+        this.playerName.setPosition(this.x, this.y - 25);
     }
 
     stop(){
@@ -95,6 +97,9 @@ export class PlayableCaracter extends Phaser.Physics.Arcade.Sprite {
     }
 
     destroy(fromScene?: boolean): void {
+        if (this.scene) {
+            this.scene.events.removeListener('postupdate', this.postupdate.bind(this));
+        }
         super.destroy(fromScene);
         this.playerName.destroy();
     }

front/src/Phaser/Player/Player.ts

@@ -62,7 +62,7 @@ export class Player extends PlayableCaracter implements CurrentGamerInterface, G
 
         let activeEvents = this.userInputManager.getEventListForGameTick();
         let speedMultiplier = activeEvents.get(UserInputEvent.SpeedUp) ? 25 : 9;
-        let moveAmount = speedMultiplier * delta;
+        let moveAmount = speedMultiplier * 20;
 
         let x = 0;
         let y = 0;
@@ -102,6 +102,5 @@ export class Player extends PlayableCaracter implements CurrentGamerInterface, G
         this.setX(MessageUserPosition.position.x);
         this.setY(MessageUserPosition.position.y);
         this.setDepth(MessageUserPosition.position.y);
-        this.updatePlayerNamePosition(MessageUserPosition.position.x, MessageUserPosition.position.y);
     }
 }