_Bastler/partey_workadventure
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #1708 from thecodingmachine/fix_firefox_private_browsing

Browse Source 
Fixing WA crashing in Firefox private mode
This commit is contained in:
David Négrier 2022-01-06 11:57:12 +01:00 committed by GitHub
commit 787cc508b8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
front/src/Connexion/ConnectionManager.ts
View File

@ -168,6 +168,9 @@ class ConnectionManager {
} }
} catch (err) { } catch (err) {
console.error(err); console.error(err);
if (err instanceof Error) {
console.error(err.stack);
}
} }
} else { } else {
const query = urlParams.toString(); const query = urlParams.toString();

4
front/src/Connexion/LocalUserStore.ts
View File

@ -139,9 +139,13 @@ class LocalUserStore {
async setLastRoomUrl(roomUrl: string): Promise<void> { async setLastRoomUrl(roomUrl: string): Promise<void> {
localStorage.setItem(lastRoomUrl, roomUrl.toString()); localStorage.setItem(lastRoomUrl, roomUrl.toString());
if ("caches" in window) { if ("caches" in window) {
try {
const cache = await caches.open(cacheAPIIndex); const cache = await caches.open(cacheAPIIndex);
const stringResponse = new Response(JSON.stringify({ roomUrl })); const stringResponse = new Response(JSON.stringify({ roomUrl }));
await cache.put(`/${lastRoomUrl}`, stringResponse); await cache.put(`/${lastRoomUrl}`, stringResponse);
} catch (e) {
console.error("Could not store last room url in Browser cache. Are you using private browser mode?", e);
}
} }
} }
getLastRoomUrl(): string { getLastRoomUrl(): string {

3
front/src/Phaser/Reconnecting/ErrorScene.ts
View File

@ -78,6 +78,9 @@ export class ErrorScene extends Phaser.Scene {
*/ */
public static showError(error: unknown, scene: ScenePlugin): void { public static showError(error: unknown, scene: ScenePlugin): void {
console.error(error); console.error(error);
if (error instanceof Error) {
console.error("Stacktrace: ", error.stack);
}
console.trace(); console.trace();
if (typeof error === "string" || error instanceof String) { if (typeof error === "string" || error instanceof String) {