_Bastler/partey_workadventure
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Properly fix the CustomizeScene by limiting input

Browse Source 
When left/right arrow is being held on chrome the Phaser gets into infinite rendering loop that doesn't crash the browser but makes it slow to a crawl.
This commit is contained in:
Dariusz Niemczyk 2020-12-27 11:00:23 +01:00 committed by GitHub
parent c9250c08f3
commit 640d994dda
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
front/src/Phaser/Login/CustomizeScene.ts
View File

@ -126,10 +126,10 @@ export class CustomizeScene extends ResizableScene {
gameManager.tryResumingGame(this, EnableCameraSceneName); gameManager.tryResumingGame(this, EnableCameraSceneName);
}); });
this.input.keyboard.on('keydown-RIGHT', () => this.moveCursorHorizontally(1)); this.input.keyboard.on('keyup-RIGHT', () => this.moveCursorHorizontally(1));
this.input.keyboard.on('keydown-LEFT', () => this.moveCursorHorizontally(-1)); this.input.keyboard.on('keyup-LEFT', () => this.moveCursorHorizontally(-1));
this.input.keyboard.on('keydown-DOWN', () => this.moveCursorVertically(1)); this.input.keyboard.on('keyup-DOWN', () => this.moveCursorVertically(1));
this.input.keyboard.on('keydown-UP', () => this.moveCursorVertically(-1)); this.input.keyboard.on('keyup-UP', () => this.moveCursorVertically(-1));
const customCursorPosition = localUserStore.getCustomCursorPosition(); const customCursorPosition = localUserStore.getCustomCursorPosition();
if (customCursorPosition) { if (customCursorPosition) {
@ -148,6 +148,7 @@ export class CustomizeScene extends ResizableScene {
this.selectedLayers[this.activeRow] = this.layers[this.activeRow].length - 1 this.selectedLayers[this.activeRow] = this.layers[this.activeRow].length - 1
} }
this.moveLayers(); this.moveLayers();
this.updateSelectedLayer();
this.saveInLocalStorage(); this.saveInLocalStorage();
} }