From 6295c8275ec6b3b3f71306ac5bb3af2ee4b2ea67 Mon Sep 17 00:00:00 2001
From: jonny <ga86lad@mytum.de>
Date: Tue, 27 Apr 2021 16:40:56 +0200
Subject: [PATCH] reset menu items on map change

---
 front/src/Phaser/Game/GameScene.ts |  3 +++
 front/src/Phaser/Menu/MenuScene.ts | 11 +++++++----
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/front/src/Phaser/Game/GameScene.ts b/front/src/Phaser/Game/GameScene.ts
index 464c3ca4..1a7a2d9f 100644
--- a/front/src/Phaser/Game/GameScene.ts
+++ b/front/src/Phaser/Game/GameScene.ts
@@ -90,6 +90,7 @@ import {LayersIterator} from "../Map/LayersIterator";
 import {touchScreenManager} from "../../Touch/TouchScreenManager";
 import {PinchManager} from "../UserInput/PinchManager";
 import {joystickBaseImg, joystickBaseKey, joystickThumbImg, joystickThumbKey} from "../Components/MobileJoystick";
+import { MenuScene, MenuSceneName } from '../Menu/MenuScene';
 
 export interface GameSceneInitInterface {
     initPosition: PointInterface|null,
@@ -880,6 +881,8 @@ ${escapedMessage}
         const {roomId, hash} = Room.getIdFromIdentifier(exitKey, this.MapUrlFile, this.instance);
         if (!roomId) throw new Error('Could not find the room from its exit key: '+exitKey);
         urlManager.pushStartLayerNameToUrl(hash);
+        const menuScene: MenuScene = this.scene.get(MenuSceneName) as MenuScene
+        menuScene.reset()
         if (roomId !== this.scene.key) {
             if (this.scene.get(roomId) === null) {
                 console.error("next room not loaded", exitKey);
diff --git a/front/src/Phaser/Menu/MenuScene.ts b/front/src/Phaser/Menu/MenuScene.ts
index 348554b3..702fb67b 100644
--- a/front/src/Phaser/Menu/MenuScene.ts
+++ b/front/src/Phaser/Menu/MenuScene.ts
@@ -38,10 +38,6 @@ export class MenuScene extends Phaser.Scene {
     private menuButton!: Phaser.GameObjects.DOMElement;
     private warningContainer: WarningContainer | null = null;
     private warningContainerTimeout: NodeJS.Timeout | null = null;
-
-    private apiMenus = []
-
-
     private subscriptions = new Subscription()
     constructor() {
         super({key: MenuSceneName});
@@ -64,6 +60,13 @@ export class MenuScene extends Phaser.Scene {
         this.load.html(warningContainerKey, warningContainerHtml);
     }
 
+    reset() {
+        const addedMenuItems=[...this.menuElement.node.querySelectorAll(".fromApi")];
+        for(let index=addedMenuItems.length-1;index>=0;index--){
+            addedMenuItems[index].remove()
+        }
+    }
+
     create() {
         this.menuElement = this.add.dom(closedSideMenuX, 30).createFromCache(gameMenuKey);
         this.menuElement.setOrigin(0);