Fine-tuning the @typescript-eslint/no-unused-vars rule

We now allow parameters to be unused. This is quite common in inherited methods.
This allows removing a bunch of: //eslint-disable-next-line @typescript-eslint/no-unused-vars
Also, "err" variables in catch MUST now be used and the special _exhaustiveCheck variable used in ":never" assigns can be unused.

pusher/.eslintrc.json

@@ -27,8 +27,8 @@
         "no-unused-vars": "off",
         "@typescript-eslint/no-explicit-any": "error",
         "@typescript-eslint/no-unused-vars": [
-            "error"
+            "error", { "args": "none", "caughtErrors": "all", "varsIgnorePattern": "_exhaustiveCheck" }
         ],
         "no-throw-literal": "error"
     }
-}
+}

pusher/src/Services/AdminApi.ts

@@ -40,12 +40,13 @@ class AdminApi implements AdminInterface {
             try {
                 authTokenData = jwtTokenManager.verifyJWTToken(authToken);
                 userId = authTokenData.identifier;
+                //eslint-disable-next-line @typescript-eslint/no-unused-vars
             } catch (e) {
                 try {
                     // Decode token, in this case we don't need to create new token.
                     authTokenData = jwtTokenManager.verifyJWTToken(authToken, true);
                     userId = authTokenData.identifier;
-                    console.info("JWT expire, but decoded", userId);
+                    console.info("JWT expire, but decoded:", userId);
                 } catch (e) {
                     if (e instanceof InvalidTokenError) {
                         throw new Error("Token decrypted error");

pusher/src/Services/LocalAdmin.ts

@@ -12,13 +12,9 @@ import { AdminApiData } from "../Messages/JsonMessages/AdminApiData";
 class LocalAdmin implements AdminInterface {
     fetchMemberDataByUuid(
         userIdentifier: string,
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         playUri: string,
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         ipAddress: string,
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         characterLayers: string[],
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         locale?: string
     ): Promise<FetchMemberDataByUuidResponse> {
         return Promise.resolve({
@@ -32,13 +28,7 @@ class LocalAdmin implements AdminInterface {
         });
     }
 
-    fetchMapDetails(
-        playUri: string,
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
-        authToken?: string,
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
-        locale?: string
-    ): Promise<MapDetailsData | RoomRedirect> {
+    fetchMapDetails(playUri: string, authToken?: string, locale?: string): Promise<MapDetailsData | RoomRedirect> {
         const roomUrl = new URL(playUri);
 
         const match = /\/_\/[^/]+\/(.+)/.exec(roomUrl.pathname);
@@ -63,65 +53,42 @@ class LocalAdmin implements AdminInterface {
     }
 
     async fetchMemberDataByToken(
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         organizationMemberToken: string,
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         playUri: string | null,
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         locale?: string
     ): Promise<AdminApiData> {
         return Promise.reject(new Error("No admin backoffice set!"));
     }
 
     reportPlayer(
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         reportedUserUuid: string,
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         reportedUserComment: string,
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         reporterUserUuid: string,
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         reportWorldSlug: string,
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         locale?: string
     ) {
         return Promise.reject(new Error("No admin backoffice set!"));
     }
 
     async verifyBanUser(
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         userUuid: string,
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         ipAddress: string,
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         roomUrl: string,
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         locale?: string
     ): Promise<AdminBannedData> {
         return Promise.reject(new Error("No admin backoffice set!"));
     }
 
-    async getUrlRoomsFromSameWorld(
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
-        roomUrl: string,
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
-        locale?: string
-    ): Promise<string[]> {
+    async getUrlRoomsFromSameWorld(roomUrl: string, locale?: string): Promise<string[]> {
         return Promise.reject(new Error("No admin backoffice set!"));
     }
 
-    getProfileUrl(
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
-        accessToken: string
-    ): string {
+    getProfileUrl(accessToken: string): string {
         new Error("No admin backoffice set!");
         return "";
     }
 
-    async logoutOauth(
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
-        token: string
-    ): Promise<void> {
+    async logoutOauth(token: string): Promise<void> {
         return Promise.reject(new Error("No admin backoffice set!"));
     }
 }

pusher/src/Services/LocalWokaService.ts

@@ -5,7 +5,6 @@ class LocalWokaService implements WokaServiceInterface {
     /**
      * Returns the list of all available Wokas & Woka Parts for the current user.
      */
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     async getWokaList(roomId: string, token: string): Promise<WokaList | undefined> {
         const wokaData: WokaList = await require("../../data/woka.json");
         if (!wokaData) {