Review of changes asked to make code cleaner

This commit is contained in:
CEC
2022-04-13 16:58:03 +02:00
parent bf40bd2f3b
commit 26dc8dbbaf
5 changed files with 26 additions and 34 deletions
+1 -1
View File
@@ -486,7 +486,7 @@ export class IoSocketController {
} else if (ws.reason === "textureInvalid") {
socketManager.emitInvalidTextureMessage(ws);
} else if (ws.reason === "error") {
socketManager.emitErrorV2Message(
socketManager.emitErrorScreenMessage(
ws,
ws.error.type,
ws.error.code,
+4 -4
View File
@@ -40,7 +40,7 @@ import {
PlayerDetailsUpdatedMessage,
LockGroupPromptMessage,
InvalidTextureMessage,
ErrorV2Message,
ErrorScreenMessage,
} from "../Messages/generated/messages_pb";
import { ProtobufUtils } from "../Model/Websocket/ProtobufUtils";
import { ADMIN_API_URL, JITSI_ISS, JITSI_URL, SECRET_JITSI_KEY } from "../Enum/EnvironmentVariable";
@@ -644,7 +644,7 @@ export class SocketManager implements ZoneEventListener {
client.send(serverToClientMessage.serializeBinary().buffer, true);
}
public emitErrorV2Message(
public emitErrorScreenMessage(
client: compressors.WebSocket,
type: string,
code: string,
@@ -656,7 +656,7 @@ export class SocketManager implements ZoneEventListener {
urlToRedirect: string,
buttonTitle: string
) {
const errorMessage = new ErrorV2Message();
const errorMessage = new ErrorScreenMessage();
errorMessage.setType(type);
errorMessage.setCode(code);
errorMessage.setTitle(title);
@@ -668,7 +668,7 @@ export class SocketManager implements ZoneEventListener {
errorMessage.setButtontitle(buttonTitle);
const serverToClientMessage = new ServerToClientMessage();
serverToClientMessage.setErrorv2message(errorMessage);
serverToClientMessage.setErrorscreenmessage(errorMessage);
//if (!client.disconnecting) {
client.send(serverToClientMessage.serializeBinary().buffer, true);