From 0aa93543bc285d7c50ef4587b1eb51bb1da1147a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20N=C3=A9grier?= <d.negrier@thecodingmachine.com>
Date: Mon, 5 Jul 2021 18:48:26 +0200
Subject: [PATCH] Adding warning if "template" object is used as a variable

---
 .../src/Phaser/Game/SharedVariablesManager.ts |  4 +++
 front/src/Phaser/Map/ITiledMap.ts             |  1 +
 front/src/iframe_api.ts                       |  2 +-
 maps/tests/Variables/variables.json           | 36 +++++++++++++++++--
 4 files changed, 40 insertions(+), 3 deletions(-)

diff --git a/front/src/Phaser/Game/SharedVariablesManager.ts b/front/src/Phaser/Game/SharedVariablesManager.ts
index dfedcf80..283eb5c3 100644
--- a/front/src/Phaser/Game/SharedVariablesManager.ts
+++ b/front/src/Phaser/Game/SharedVariablesManager.ts
@@ -48,6 +48,10 @@ export class SharedVariablesManager {
             if (layer.type === 'objectgroup') {
                 for (const object of layer.objects) {
                     if (object.type === 'variable') {
+                        if (object.template) {
+                            console.warn('Warning, a variable object is using a Tiled "template". WorkAdventure does not support objects generated from Tiled templates.')
+                        }
+
                         // We store a copy of the object (to make it immutable)
                         objects.set(object.name, this.iTiledObjectToVariable(object));
                     }
diff --git a/front/src/Phaser/Map/ITiledMap.ts b/front/src/Phaser/Map/ITiledMap.ts
index c5b96f22..57bb13c9 100644
--- a/front/src/Phaser/Map/ITiledMap.ts
+++ b/front/src/Phaser/Map/ITiledMap.ts
@@ -141,6 +141,7 @@ export interface ITiledMapObject {
     polyline: { x: number; y: number }[];
 
     text?: ITiledText;
+    template?: string;
 }
 
 export interface ITiledText {
diff --git a/front/src/iframe_api.ts b/front/src/iframe_api.ts
index da2e922e..cd610ab0 100644
--- a/front/src/iframe_api.ts
+++ b/front/src/iframe_api.ts
@@ -190,7 +190,7 @@ window.addEventListener(
     }
     const payload = message.data;
 
-    console.debug(payload);
+    //console.debug(payload);
 
     if (isIframeErrorAnswerEvent(payload)) {
         const queryId = payload.id;
diff --git a/maps/tests/Variables/variables.json b/maps/tests/Variables/variables.json
index 61067071..94d40560 100644
--- a/maps/tests/Variables/variables.json
+++ b/maps/tests/Variables/variables.json
@@ -68,8 +68,40 @@
                  "y":2.5
                 }, 
                 {
+                 "height":0,
                  "id":5,
-                 "template":"config.tx",
+                 "name":"config",
+                 "point":true,
+                 "properties":[
+                        {
+                         "name":"default",
+                         "type":"string",
+                         "value":"{}"
+                        }, 
+                        {
+                         "name":"jsonSchema",
+                         "type":"string",
+                         "value":"{}"
+                        }, 
+                        {
+                         "name":"persist",
+                         "type":"bool",
+                         "value":true
+                        }, 
+                        {
+                         "name":"readableBy",
+                         "type":"string",
+                         "value":""
+                        }, 
+                        {
+                         "name":"writableBy",
+                         "type":"string",
+                         "value":"admin"
+                        }],
+                 "rotation":0,
+                 "type":"variable",
+                 "visible":true,
+                 "width":0,
                  "x":57.5,
                  "y":111
                 }, 
@@ -98,7 +130,7 @@
          "y":0
         }],
  "nextlayerid":8,
- "nextobjectid":8,
+ "nextobjectid":9,
  "orientation":"orthogonal",
  "properties":[
         {